Update gas and nonce management for Ethereum #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
requested review from
aklenik,
feihujiang,
jiangyaoguo,
liam-grace,
nklincoln and
panyu4
as code owners
aklenik
requested changes
Nov 6, 2019
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); |
There was a problem hiding this comment.
Space is not allowed before the *, the checker complains.
* Estimating gas is now an explicit opt in, and secondary to explicit gas values. * Nonces are only added if caliper signs the transactions * Update explicit gas in simple transfer queries Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gas values.
Signed-off-by: Danno Ferrin <[email protected]>